Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add handling of absolute url path in ignore-file #1014

Merged
merged 3 commits into from
Feb 20, 2023

Conversation

SmoliyY
Copy link
Contributor

@SmoliyY SmoliyY commented Feb 20, 2023

What/Why/How?

Fix bug if remote schema from added to ignore file.
Fix output for errors if its is url as a pointer

Reference

Closes #1013

Testing

Screenshots (optional)

Screenshot 2023-02-20 at 16 24 30

Screenshot 2023-02-20 at 16 24 38

Check yourself

  • Code is linted
  • Tested with redoc/reference-docs/workflows
  • All new/updated code is covered with tests

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

@github-actions
Copy link
Contributor

github-actions bot commented Feb 20, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 73.82% 3437/4656
🟡 Branches 65% 1959/3014
🟡 Functions 66.17% 579/875
🟡 Lines 73.84% 3196/4328
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟡
... / config.ts
71.05% 76.19% 65.38% 70.5%
🔴
... / format.ts
34.67%
14.47% (-5.17% 🔻)
30.43% 34.51%

Test suite run success

566 tests passing in 85 suites.

Report generated by 🧪jest coverage report action from 207b028

@SmoliyY SmoliyY marked this pull request as ready for review February 20, 2023 14:25
@SmoliyY SmoliyY requested a review from a team as a code owner February 20, 2023 14:25
packages/core/src/config/config.ts Outdated Show resolved Hide resolved
packages/core/src/config/config.ts Outdated Show resolved Hide resolved
@SmoliyY SmoliyY merged commit 28e7e83 into main Feb 20, 2023
@SmoliyY SmoliyY deleted the fix/absoulte-url-path-in-ignore-file branch February 20, 2023 15:48
@SmoliyY SmoliyY mentioned this pull request Mar 9, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remote schema errors are not being ignored by lint-ignore-file
3 participants